Uh oh!
There was an error while loading. Please reload this page.
Use correct SVG icon on share view - #7580
Closed
pixelipo wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Marin Treselj <marin@pixelipo.com>
MorrisJobke
commented
Dec 19, 2017
Member
Acceptance tests fail: |
pixelipo
commented
Dec 19, 2017
ContributorAuthor
That's baffling. This PR could not possibly cause that failure. Any ideas? |
juliusknorr
requested changes
Dec 19, 2017
juliusknorr
left a comment
Member
There was a problem hiding this comment.
The logo should not be stretched to the whole container when we use the default Nextcloud logo. Similar to #4910
rullzer
commented
Jan 2, 2018
Member
@pixelipo any chance you can take a look at the comment from @juliushaertl ? |
MorrisJobke
commented
Jan 3, 2018
Member
Merged as #7670 🤣 |
juliusknorr
commented
Jan 3, 2018
Member
Addressed the logo sizing in #7678 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while testing #7575 - it seems that $image-logo SCSS variable was pointing to a deprecated SVG image.


Before:
After:

