Uh oh!
There was an error while loading. Please reload this page.
Conversation
rullzer
requested review from
MorrisJobke, blizzz, georgehrke and nickvergessenDecember 29, 2017 13:17
blizzz
approved these changes
Dec 29, 2017
Codecov Report
@@ Coverage Diff @@## master #7644 +/- ##
============================================
- Coverage 52.8% 51.17% -1.63% - Complexity 23574 24884 +1310
============================================
Files 1445 1601 +156 Lines 80331 94745 +14414 Branches 0 1368 +1368 ============================================
+ Hits 42416 48483 +6067 - Misses 37915 46262 +8347
|
Fixes#7184 The SyncJob can be very resource intensive. Since it requests all users on the system to create the system addressbook. In order to do this it creates a vcard for every user and updates the addressbook. There is no need for this job since the proper signals are emitted and handled in the carddav backend to update the addressbook live. Worst comes to worst there is always the occ command to bring the address book in sync again. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
approved these changes
Jan 2, 2018
hostingnuggets
commented
Jan 2, 2018
Can we also have this fix in Nextcloud 12? |
rullzer
commented
Jan 2, 2018
MemberAuthor
@hostingnuggets yes I think that makes sense |
hostingnuggets
commented
Jan 2, 2018
@rullzer that would be great thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#7184
See: #7184 (comment)
The SyncJob can be very resource intensive. Since it requests all users
on the system to create the system addressbook. In order to do this it
creates a vcard for every user and updates the addressbook.
There is no need for this job since the proper signals are emitted and
handled in the carddav backend to update the addressbook live.
Worst comes to worst there is always the occ command to bring the
address book in sync again.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl