Uh oh!
There was an error while loading. Please reload this page.
[stable12] Do no run SyncJob in cron - #7674
Merged
Merged
Conversation
Fixes#7184 The SyncJob can be very resource intensive. Since it requests all users on the system to create the system addressbook. In order to do this it creates a vcard for every user and updates the addressbook. There is no need for this job since the proper signals are emitted and handled in the carddav backend to update the addressbook live. Worst comes to worst there is always the occ command to bring the address book in sync again. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
MorrisJobke, blizzz, georgehrke and nickvergessenJanuary 3, 2018 09:59
Codecov Report
@@ Coverage Diff @@## stable12 #7674 +/- ##
==============================================
+ Coverage 53.93% 53.93% +<.01% + Complexity 22712 22710 -2
==============================================
Files 1385 1384 -1 Lines 86996 86990 -6 Branches 1330 1330 ==============================================
- Hits 46919 46918 -1 + Misses 40077 40072 -5
|
blizzz
approved these changes
Jan 3, 2018
MorrisJobke
approved these changes
Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7644