Skip to content

Fix url rebase when changing the theming color - #7710

Merged
MorrisJobke merged 1 commit into
masterfrom
theming-fix-scss
Jan 5, 2018
Merged

Fix url rebase when changing the theming color#7710
MorrisJobke merged 1 commit into
masterfrom
theming-fix-scss

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

fix for #7704

taken from #7688

skjnldsv
skjnldsv previously requested changes Jan 5, 2018

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop my commits, there not needed! :)

Signed-off-by: Julius Härtl <jus@bitgrid.net>

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 5, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Jan 5, 2018
30 tasks
@MorrisJobke
MorrisJobke merged commit ad8e9b2 into masterJan 5, 2018
@codecov

codecovBot commented Jan 5, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7710 into master will increase coverage by 16.29%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #7710 +/- ##
=============================================
+ Coverage 34.88% 51.18% +16.29% - Complexity 23636 24948 +1312 
=============================================
Files 1512 1605 +93 Lines 90182 94925 +4743 Branches 1376 1376 =============================================
+ Hits 31461 48584 +17123 + Misses 58721 46341 -12380
Impacted FilesCoverage ΔComplexity Δ
apps/theming/lib/Controller/ThemingController.php75.38% <100%> (+71.15%)43 <0> (ø)⬇️
lib/private/Server.php81.43% <0%> (-0.12%)134% <0%> (ø)
apps/files_external/lib/Lib/MissingDependency.php100% <0%> (ø)4% <0%> (?)
apps/files_external/lib/Command/Config.php0% <0%> (ø)15% <0%> (?)
apps/files_external/lib/Lib/Backend/Backend.php96.66% <0%> (ø)11% <0%> (?)
...external/lib/Controller/UserStoragesController.php48.14% <0%> (ø)12% <0%> (?)
...ternal/lib/Controller/GlobalStoragesController.php36.25% <0%> (ø)8% <0%> (?)
apps/files_external/lib/Settings/Admin.php74.07% <0%> (ø)4% <0%> (?)
apps/files_external/lib/Lib/IdentifierTrait.php63.63% <0%> (ø)8% <0%> (?)
apps/files_external/lib/Service/BackendService.php90.27% <0%> (ø)34% <0%> (?)
... and 614 more

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: themingregression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@MorrisJobke@skjnldsv