Uh oh!
There was an error while loading. Please reload this page.
Fix SCSS processing when undoing theming values - #7756
Merged
Conversation
Signed-off-by: Julius Härtl <jus@bitgrid.net>
skjnldsv
approved these changes
Jan 9, 2018
skjnldsv
commented
Jan 9, 2018
Member
Could be great to have some testing on this 🙈 🙉 🙊 |
Codecov Report
@@ Coverage Diff @@## master #7756 +/- ##
=========================================
Coverage 51.17% 51.17% Complexity 24959 24959 =========================================
Files 1605 1605 Lines 94950 94950 Branches 1376 1376 =========================================
Hits 48588 48588 Misses 46362 46362
|
MorrisJobke
approved these changes
Jan 9, 2018
juliusknorr
commented
Jan 10, 2018
MemberAuthor
backport at #7770 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @skjnldsv on IRC, rebasing of urls in SCSS doesn't work when resetting values in the theming app. This PR fixes that behaviour as well.
Signed-off-by: Julius Härtl jus@bitgrid.net
Follow-up pr of #7710
probably fixes#7721 as well
@nextcloud/theming