Skip to content

Keep all shipped apps enabled because they should be okay - #7879

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/7865/dont-disable-shipped-apps-on-errors
Jan 16, 2018
Merged

Keep all shipped apps enabled because they should be okay#7879
MorrisJobke merged 1 commit into
masterfrom
bugfix/7865/dont-disable-shipped-apps-on-errors

Conversation

@nickvergessen

@nickvergessennickvergessen commented Jan 16, 2018

Copy link
Copy Markdown
Member

@nickvergessen
Keep all shipped apps enabled because they should be okay
c95890f
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessennickvergessen added bug 3. to review Waiting for reviews labels Jan 16, 2018
@nickvergessennickvergessen added this to the Nextcloud 14 milestone Jan 16, 2018
rullzer
rullzer approved these changes Jan 16, 2018
View reviewed changes

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At leasts fixes most of the effect from the issue

blizzz
blizzz approved these changes Jan 16, 2018
View reviewed changes

@blizzzblizzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a start :)

@blizzzblizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2018
@codecov

codecovBot commented Jan 16, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #7879 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #7879 +/- ##
============================================
- Coverage 51.24% 51.24% -0.01% 
Complexity 24931 24931 ============================================
Files 1604 1604 Lines 94970 94969 -1 Branches 1376 1376 ============================================
- Hits 48670 48668 -2 - Misses 46300 46301 +1
Impacted FilesCoverage ΔComplexity Δ
lib/private/legacy/app.php54.17% <0%> (+0.1%)222 <0> (ø)⬇️
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)
lib/public/User.php50% <0%> (ø)10% <0%> (ø)⬇️

@MorrisJobke
MorrisJobke merged commit 9a99fc0 into masterJan 16, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/7865/dont-disable-shipped-apps-on-errors branch January 16, 2018 12:36
@MorrisJobke

MorrisJobke commented Jan 16, 2018

Copy link
Copy Markdown
Member

@nickvergessen Could you open the backport to stable13? Thanks

@MorrisJobke

MorrisJobke commented Jan 16, 2018

Copy link
Copy Markdown
Member

And stable12

This was referenced Jan 16, 2018
Merged
Merged
@nickvergessen

nickvergessen commented Jan 16, 2018

Copy link
Copy Markdown
MemberAuthor

Done ^

@MorrisJobkeMorrisJobke mentioned this pull request Jan 30, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@blizzzblizzzblizzz approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen@MorrisJobke@rullzer@blizzz