Skip to content

[stable12] Keep all shipped apps enabled because they should be okay - #7888

Merged
rullzer merged 1 commit into
stable12from
backport/7879/dont-disable-shipped-apps-on-errors-12
Jan 16, 2018
Merged

[stable12] Keep all shipped apps enabled because they should be okay#7888
rullzer merged 1 commit into
stable12from
backport/7879/dont-disable-shipped-apps-on-errors-12

Conversation

@nickvergessen

Copy link
Copy Markdown
Member

Backport #7879

Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke

Copy link
Copy Markdown
Member

Is it okay to put this into 12.0.5 maybe?

@rullzer

Copy link
Copy Markdown
Member

@MorrisJobke fine by me

@MorrisJobke

Copy link
Copy Markdown
Member

@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2018
@codecov

codecovBot commented Jan 16, 2018

Copy link
Copy Markdown

Codecov Report

Merging #7888 into stable12 will increase coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## stable12 #7888 +/- ##
==============================================
+ Coverage 53.84% 53.84% +<.01% 
Complexity 22758 22758 ==============================================
Files 1385 1385 Lines 87148 87147 -1 Branches 1331 1331 ==============================================
Hits 46926 46926 + Misses 40222 40221 -1
Impacted FilesCoverage ΔComplexity Δ
lib/private/legacy/app.php52.8% <0%> (+0.1%)219 <0> (ø)⬇️
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
lib/private/Server.php84.68% <0%> (-0.13%)121% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️
lib/private/Security/CertificateManager.php92.07% <0%> (+0.99%)39% <0%> (ø)⬇️

@rullzer
rullzer merged commit 60fa75d into stable12Jan 16, 2018
@rullzer
rullzer deleted the backport/7879/dont-disable-shipped-apps-on-errors-12 branch January 16, 2018 19:19
@MorrisJobkeMorrisJobke mentioned this pull request Jan 18, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@nickvergessen@MorrisJobke@rullzer