Uh oh!
There was an error while loading. Please reload this page.
Fix missing clipboard icon in shared links - #8032
Merged
Merged
Conversation
The clipboard icon in shared links appears either directly on the link input field or, if any social sharing app is enabled, in a menu. The clipboard icon uses the same CSS rules as other icons (like the information icon) to be posioned on the end of the input field, and those rules have to be "cancelled" when the icon is shown in the menu. Fixes#7990 Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Closed
Codecov Report
@@ Coverage Diff @@## master #8032 +/- ##
============================================
+ Coverage 51.22% 51.39% +0.16% + Complexity 24865 24862 -3
============================================
Files 1598 1590 -8 Lines 94922 94591 -331 Branches 1376 1376 ============================================
- Hits 48626 48614 -12 + Misses 46296 45977 -319 |
MorrisJobke
approved these changes
Jan 24, 2018
MorrisJobke
commented
Jan 24, 2018
Member
Let me do the backport. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixesa regression introduced in #7476 when fixing a regression introduced in #7064 (Inception is a great movie, by the way :-P ).
In #7064a padding of 0 was removed from menu items; as the padding of the Copy menu item was no longer forced to 0 it ended with a large padding.
This was fixed in #7476 by removing all the padding from the clipboard icon, but as the padding (and other CSS rules) were removed also when the clipboard icon was not in the menu it was no longer properly shown in the link input field.
This pull request restores the CSS rules when the clipboard icon is shown in the link input field and also forces the padding to 0 when it is in the menu, which causes the icon to be shown as expected in both cases (and I hope that I have not inadvertently introduced yet another regression :-P ).
@nextcloud/designers