Skip to content

SCSS hardening - #8078

Merged
MorrisJobke merged 8 commits into
masterfrom
theming-validate-scss
Jan 29, 2018
Merged

SCSS hardening#8078
MorrisJobke merged 8 commits into
masterfrom
theming-validate-scss

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jan 26, 2018

Copy link
Copy Markdown
Member

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov

codecovBot commented Jan 26, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8078 into master will decrease coverage by 45.09%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #8078 +/- ##
===========================================
- Coverage 51.7% 6.6% -45.1% - Complexity 25426 25428 +2 
===========================================
Files 1598 1598 Lines 95241 95251 +10 Branches 1376 1376 ===========================================
- Hits 49243 6293 -42950 - Misses 45998 88958 +42960
Impacted FilesCoverage ΔComplexity Δ
apps/theming/lib/ThemingDefaults.php0% <0%> (-91.8%)46 <0> (ø)
lib/private/Template/SCSSCacher.php0% <0%> (-71.1%)39 <0> (+2)
...eLimiting/Exception/RateLimitExceededException.php0% <0%> (-100%)1% <0%> (ø)
...yBuilder/FunctionBuilder/SqliteFunctionBuilder.php0% <0%> (-100%)1% <0%> (ø)
lib/private/Remote/InstanceFactory.php0% <0%> (-100%)2% <0%> (ø)
apps/files_versions/lib/AppInfo/Application.php0% <0%> (-100%)2% <0%> (ø)
apps/encryption/lib/Session.php0% <0%> (-100%)21% <0%> (ø)
apps/oauth2/lib/Db/Client.php0% <0%> (-100%)1% <0%> (ø)
apps/dav/lib/Connector/Sabre/Server.php0% <0%> (-100%)1% <0%> (ø)
...b/public/AppFramework/Db/DoesNotExistException.php0% <0%> (-100%)1% <0%> (ø)
... and 860 more

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
return false;
}
}
return true;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes please... the old code was clearly me messing up 😉

@skjnldsv

Copy link
Copy Markdown
Member

Awesome!!! Thanks @juliushaertl !

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MorrisJobke
MorrisJobke merged commit 4fcdfbf into masterJan 29, 2018
@MorrisJobke
MorrisJobke deleted the theming-validate-scss branch January 29, 2018 15:12
@juliusknorrjuliusknorr mentioned this pull request Feb 2, 2018
@juliusknorr

Copy link
Copy Markdown
MemberAuthor

backport at #8156

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CSS is not properly rendered after upgrade from 11 to 12.0.4 NC12 slow with multiple domains

4 participants

@juliusknorr@skjnldsv@rullzer@MorrisJobke