Skip to content

[Stable13] Scss hardening - #8156

Merged
MorrisJobke merged 7 commits into
stable13from
stable13-8078
Feb 6, 2018
Merged

[Stable13] Scss hardening#8156
MorrisJobke merged 7 commits into
stable13from
stable13-8078

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

Backport of #8078 without the typehinting.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@codecov

codecovBot commented Feb 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8156 into stable13 will increase coverage by <.01%.
The diff coverage is 57.14%.

@@ Coverage Diff @@## stable13 #8156 +/- ##
==============================================
+ Coverage 51.23% 51.23% +<.01% - Complexity 24982 24984 +2 
==============================================
Files 1607 1607 Lines 95050 95060 +10 Branches 1376 1376 ==============================================
+ Hits 48695 48702 +7 - Misses 46355 46358 +3
Impacted FilesCoverage ΔComplexity Δ
apps/theming/lib/ThemingDefaults.php91.79% <100%> (ø)46 <0> (ø)⬇️
lib/private/Template/SCSSCacher.php69.56% <50%> (-1.53%)39 <0> (+2)
core/js/js.js66.4% <0%> (+0.11%)0% <0%> (ø)⬇️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@MorrisJobke
MorrisJobke merged commit b206870 into stable13Feb 6, 2018
@MorrisJobke
MorrisJobke deleted the stable13-8078 branch February 6, 2018 11:17
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugfeature: scss

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@rullzer@MorrisJobke