Skip to content

Fix deleting folders when using s3 external storage - #8100

Merged
MorrisJobke merged 2 commits into
masterfrom
s3-folder-delete
Feb 8, 2018
Merged

Fix deleting folders when using s3 external storage#8100
MorrisJobke merged 2 commits into
masterfrom
s3-folder-delete

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Fixes#7667

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Jan 29, 2018
@icewind1991icewind1991 added this to the Nextcloud 14 milestone Jan 29, 2018
@MorrisJobke

Copy link
Copy Markdown
Member

@wildlifechorus@schnaser@Flandoll Please help testing this :)

@codecov

codecovBot commented Jan 29, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8100 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #8100 +/- ##
===========================================
- Coverage 51.7% 51.7% -0.01% - Complexity 25427 25428 +1 
===========================================
Files 1598 1598 Lines 95239 95242 +3 Branches 1376 1376 ===========================================
Hits 49244 49244 - Misses 45995 45998 +3
Impacted FilesCoverage ΔComplexity Δ
apps/files_external/lib/Lib/Storage/AmazonS3.php0% <0%> (ø)111 <0> (+1)⬆️
lib/private/Server.php85.24% <0%> (-0.1%)281% <0%> (ø)
lib/private/Security/CertificateManager.php92% <0%> (+1%)39% <0%> (ø)⬇️

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@MorrisJobke
MorrisJobke merged commit 12c9bad into masterFeb 8, 2018
@MorrisJobke
MorrisJobke deleted the s3-folder-delete branch February 8, 2018 13:11
@MorrisJobke

Copy link
Copy Markdown
Member

I guess this needs to be backported tos table12/13?

@Disco1

Copy link
Copy Markdown

I'm having the same issue. Trying to delete certain files and folders from S3 causes an error "unable to delete". There is nothing in the nextcloud.log that points to anything of interest. I have verified that the attached fix patch has been applied to my instance (newly downloaded). Any ideas?

@kesselb

Copy link
Copy Markdown
Contributor

@Disco1 would you mind to create a issue report https://github.com/nextcloud/server/issues/new?labels=bug%2C+0.+Needs+triage&template=Bug_report.md for this? This pull request is not the right place.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to delete folder inside S3

5 participants

@icewind1991@MorrisJobke@Disco1@kesselb@rullzer