Skip to content

[12] Fix deleting folders when using s3 external storage - #8262

Merged
rullzer merged 2 commits into
stable12from
s3-folder-delete-12
Feb 13, 2018
Merged

[12] Fix deleting folders when using s3 external storage#8262
rullzer merged 2 commits into
stable12from
s3-folder-delete-12

Conversation

@icewind1991

Copy link
Copy Markdown
Member

Backport of #8100

@icewind1991icewind1991 added the 3. to review Waiting for reviews label Feb 8, 2018
@icewind1991icewind1991 added this to the Nextcloud 12.0.6 milestone Feb 8, 2018
@mention-bot

Copy link
Copy Markdown

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Xenopathic to be a potential reviewer.

Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
@codecov

codecovBot commented Feb 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8262 into stable12 will decrease coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## stable12 #8262 +/- ##
==============================================
- Coverage 53.84% 53.84% -0.01% - Complexity 22754 22755 +1 
==============================================
Files 1386 1386 Lines 87126 87129 +3 Branches 1331 1331 ==============================================
- Hits 46915 46914 -1 - Misses 40211 40215 +4
Impacted FilesCoverage ΔComplexity Δ
apps/files_external/lib/Lib/Storage/AmazonS3.php0% <0%> (ø)111 <0> (+1)⬆️
apps/files_trashbin/lib/Trashbin.php72.28% <0%> (-0.25%)136% <0%> (ø)

@rullzer
rullzer merged commit 74bc89f into stable12Feb 13, 2018
@rullzer
rullzer deleted the s3-folder-delete-12 branch February 13, 2018 06:45
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@icewind1991@mention-bot@rullzer@MorrisJobke