Skip to content

Use a phan version instead of master - #8172

Merged
danxuliu merged 3 commits into
masterfrom
phan-version
Feb 5, 2018
Merged

Use a phan version instead of master#8172
danxuliu merged 3 commits into
masterfrom
phan-version

Conversation

@rullzer

Copy link
Copy Markdown
Member

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer

Copy link
Copy Markdown
MemberAuthor

Seems we need toe extend the php7.2 image.... I might look into this this evening.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

codecovBot commented Feb 5, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8172 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #8172 +/- ##
============================================
+ Coverage 51.73% 51.74% +<.01% - Complexity 25357 25365 +8 
============================================
Files 1598 1599 +1 Lines 95021 95061 +40 Branches 1376 1376 ============================================
+ Hits 49159 49186 +27 - Misses 45862 45875 +13
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Cache/Wrapper/CacheJail.php87.5% <0%> (-0.88%)40% <0%> (+1%)
lib/private/Server.php83.18% <0%> (-0.55%)282% <0%> (+1%)
lib/private/Repair.php31.34% <0%> (-0.48%)19% <0%> (ø)
lib/private/TemplateLayout.php0% <0%> (ø)48% <0%> (+2%)⬆️
lib/private/Repair/ClearFrontendCaches.php63.15% <0%> (ø)4% <0%> (?)
apps/files_trashbin/lib/Trashbin.php72.7% <0%> (+0.24%)136% <0%> (ø)⬇️
lib/private/Template/JSCombiner.php89.1% <0%> (+0.93%)30% <0%> (+3%)⬆️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️
lib/private/Template/SCSSCacher.php71.53% <0%> (+1.96%)36% <0%> (-3%)⬇️

@rullzer

Copy link
Copy Markdown
MemberAuthor

Yay phan is happy again....

@rullzerrullzer added this to the Nextcloud 14 milestone Feb 5, 2018
@rullzerrullzer added the 3. to review Waiting for reviews label Feb 5, 2018

@danxuliudanxuliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drone is happy and changes make sense (for reference, Phan 0.11.x requires PHP 7.2 and the php7.2-11 release of nextcloudci/php7.2 added support for Redis and Imagick, which are needed by Phan tests) 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer@icewind1991@ChristophWurst@danxuliu@MorrisJobke