Uh oh!
There was an error while loading. Please reload this page.
[stable13] Use a phan version instead of master - #8195
Conversation
There was a problem hiding this comment.
Phan 0.11.1 requires PHP 7.2, but its image version was not bumped (second commit from original pull request was not included in this oneedit: well, second commit would not be valid on its own either; it would require the bump from the third one anyway to use the latest PHP 7.2 image).
Codecov Report
@@ Coverage Diff @@## stable13 #8195 +/- ##
===========================================
Coverage 51.23% 51.23% Complexity 24985 24985 ===========================================
Files 1607 1607 Lines 95062 95062 Branches 1376 1376 ===========================================
Hits 48701 48701 Misses 46361 46361 |
MorrisJobke
commented
Feb 6, 2018
also 7.2-11 contains already a newer PHPUnit - so I used the old php 7.2-9 image ;) Let's see |
danxuliu
commented
Feb 6, 2018
Phan needs Redis and Imagick, which were included in 7.2-11. Is the newer PHPUnit incompatible with Phan tests in stable13? In that case I guess that we will have to use Phan 0.10.x for stable13, as Phan 0.10.x is compatible with PHP 7.1. |
rullzer
commented
Feb 6, 2018
Aaah right... yeah just use the one compatible with 7.1 for 13 then i think. |
MorrisJobke
commented
Feb 6, 2018
I just wanted to keep the versions the same. Let me try with 7.2-11 and if this does not work we will use 0.10.x of phan. |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
danxuliu
commented
Feb 6, 2018
Drone is happy with 7.2-11 :-D |
Backport of #8172