Skip to content

[stable13] Handle SSL certificate verifications for others than Let's Encrypt - #8183

Merged
MorrisJobke merged 1 commit into
nextcloud:stable13from
robert-scheck:pki-validation-stable13
Feb 8, 2018
Merged

[stable13] Handle SSL certificate verifications for others than Let's Encrypt#8183
MorrisJobke merged 1 commit into
nextcloud:stable13from
robert-scheck:pki-validation-stable13

Conversation

@robert-scheck

@robert-scheckrobert-scheck commented Feb 5, 2018

Copy link
Copy Markdown
Contributor

Backport of #8182

Do no longer (wrongly) rewrite URLs like

for automated SSL certificate verifications. All (common commercial) certificate authorities (CA) except Let's Encrypt (via ACME) seem to use "pki-validation" rather "acme-challenge" for their domain control validation (DCV).

Signed-off-by: Robert Scheck robert@fedoraproject.org

Do no longer (wrongly) rewrite URLs like
* http://example.net/.well-known/pki-validation/file.txt (Comodo)
* http://example.net/.well-known/pki-validation/fileauth.txt (DigiCert, Thawte, GeoTrust)
* http://example.net/.well-known/pki-validation/gsdv.txt (GlobalSign)
* http://example.net/.well-known/pki-validation/starfield.htm (Starfield, GoDaddy)
* http://example.net/.well-known/pki-validation/swisssign-check.txt (SwissSign)
for automated SSL certificate verifications. All (common commercial)
certificate authorities (CA) except Let's Encrypt (via ACME) seem to
use "pki-validation" rather "acme-challenge" for their domain control
validation (DCV).
Signed-off-by: Robert Scheck <robert@fedoraproject.org>
@robert-scheckrobert-scheck changed the title Handle SSL certificate verifications for others than Let's Encrypt[stable13] Handle SSL certificate verifications for others than Let's EncryptFeb 5, 2018
@nickvergessennickvergessen added the 3. to review Waiting for reviews label Feb 6, 2018
@nickvergessennickvergessen added this to the Nextcloud 13.0.1 milestone Feb 6, 2018
@MorrisJobke

Copy link
Copy Markdown
Member

Phan failure is fixed in stable13 (#8195)

@MorrisJobke

Copy link
Copy Markdown
Member

CI failure was fixed in #8195

@MorrisJobke
MorrisJobke merged commit e2cb6a3 into nextcloud:stable13Feb 8, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@robert-scheck@MorrisJobke@nickvergessen