Skip to content

[stable12] Also make sure remote.php and public.php don't work on 7.2 - #8209

Closed
rullzer wants to merge 1 commit into
stable12from
fix_7415
Closed

[stable12] Also make sure remote.php and public.php don't work on 7.2#8209
rullzer wants to merge 1 commit into
stable12from
fix_7415

Conversation

@rullzer

Copy link
Copy Markdown
Member

Fixes#7415

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes#7415
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov

codecovBot commented Feb 6, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8209 into stable12 will decrease coverage by 0.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## stable12 #8209 +/- ##
==============================================
- Coverage 53.84% 53.82% -0.02% 
Complexity 22762 22762 ==============================================
Files 1385 1385 Lines 87152 87168 +16 Branches 1331 1331 ==============================================
- Hits 46926 46922 -4 - Misses 40226 40246 +20
Impacted FilesCoverage ΔComplexity Δ
public.php0% <0%> (ø)0 <0> (ø)⬇️
remote.php0% <0%> (ø)0 <0> (ø)⬇️
core/js/js.js61.27% <0%> (-0.56%)0% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️

@danxuliudanxuliu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to backport #6830 (as it covers too other files like cron.php or status.php)?

@rullzer

Copy link
Copy Markdown
MemberAuthor

in theory I guess...

@MorrisJobke

Copy link
Copy Markdown
Member

Wouldn't it be better to backport #6830 (as it covers too other files like cron.php or status.php)?

Please do that.

@rullzer

Copy link
Copy Markdown
MemberAuthor

see #8216

@rullzerrullzer closed this Feb 7, 2018
@rullzer
rullzer deleted the fix_7415 branch February 7, 2018 09:49
@MorrisJobkeMorrisJobke removed this from the Nextcloud 12.0.6 milestone Feb 7, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@danxuliu