Skip to content

[stable13] Fix retrieval of group members with numerical uids from LDAP - #8536

Merged
MorrisJobke merged 2 commits into
stable13from
8522-stable13
Feb 26, 2018
Merged

[stable13] Fix retrieval of group members with numerical uids from LDAP#8536
MorrisJobke merged 2 commits into
stable13from
8522-stable13

Conversation

@blizzz

@blizzzblizzz commented Feb 26, 2018

Copy link
Copy Markdown
Member

backport from #8522

@blizzz
tests for retrieving group members with numerical uids
b02d3a2
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fix retrieving group members with numerical uids from LDAP
8acec53
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 13.0.1 milestone Feb 26, 2018
@blizzzblizzz mentioned this pull request Feb 26, 2018
Merged
@codecov

codecovBot commented Feb 26, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8536 into stable13 will increase coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable13 #8536 +/- ##
==============================================
+ Coverage 51.23% 51.23% +<.01% 
Complexity 24987 24987 ==============================================
Files 1608 1608 Lines 95100 95100 Branches 1376 1376 ==============================================
+ Hits 48721 48722 +1 + Misses 46379 46378 -1
Impacted FilesCoverage ΔComplexity Δ
apps/user_ldap/lib/Group_LDAP.php62.03% <100%> (ø)176 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️

@MorrisJobke
MorrisJobke merged commit bf2f744 into stable13Feb 26, 2018
@MorrisJobke
MorrisJobke deleted the 8522-stable13 branch February 26, 2018 14:10
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
Merged
10 tasks
@tanguy-opendsitanguy-opendsi mentioned this pull request May 7, 2018
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: ldap

Projects

None yet

Milestone

Nextcloud 13.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@blizzz@rullzer@MorrisJobke