Uh oh!
There was an error while loading. Please reload this page.
Fix retrieval of group members with numerical uids from LDAP - #8522
Merged
Conversation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
requested review from
ChristophWurst, MorrisJobke, nickvergessen and rullzerFebruary 23, 2018 11:08
blizzz
commented
Feb 23, 2018
MemberAuthor
Swift test ran in a time out, but is unrelated to the changes |
MorrisJobke
approved these changes
Feb 26, 2018
blizzz
commented
Feb 26, 2018
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More array_merge fun… comes with unit test
Basic issue: when your LDAP group references group members with uids (not full DNs) and those uids are purely numeric, array_merge would resort-them, starting with 0.
@nextcloud/ldap