Skip to content

[stable12] Fix retrieval of group members with numerical uids from LDAP - #8537

Merged
MorrisJobke merged 2 commits into
stable12from
8522-stable12
Feb 26, 2018
Merged

[stable12] Fix retrieval of group members with numerical uids from LDAP #8537
MorrisJobke merged 2 commits into
stable12from
8522-stable12

Conversation

@blizzz

@blizzzblizzz commented Feb 26, 2018

Copy link
Copy Markdown
Member

backport from #8522

@blizzz
tests for retrieving group members with numerical uids
90a70fb
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
fix retrieving group members with numerical uids from LDAP
0b51ce6
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzzblizzz added this to the Nextcloud 12.0.6 milestone Feb 26, 2018
@blizzzblizzz changed the title 8522 stable12[stable12] Fix retrieval of group members with numerical uids from LDAP Feb 26, 2018
@blizzzblizzz mentioned this pull request Feb 26, 2018
Merged
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 26, 2018
@codecov

codecovBot commented Feb 26, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #8537 into stable12 will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## stable12 #8537 +/- ##
===========================================
Coverage 53.84% 53.84% Complexity 22757 22757 ===========================================
Files 1386 1386 Lines 87141 87141 Branches 1331 1331 ===========================================
Hits 46920 46920 Misses 40221 40221
Impacted FilesCoverage ΔComplexity Δ
apps/user_ldap/lib/Group_LDAP.php60.11% <100%> (ø)160 <0> (ø)⬇️
apps/files_trashbin/lib/Expiration.php90.32% <0%> (-1.62%)29% <0%> (ø)
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@MorrisJobke
MorrisJobke merged commit ee01068 into stable12Feb 26, 2018
@MorrisJobke
MorrisJobke deleted the 8522-stable12 branch February 26, 2018 14:09
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
Merged
2 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: ldap

Projects

None yet

Milestone

Nextcloud 12.0.6

Development

Successfully merging this pull request may close these issues.

4 participants

@blizzz@rullzer@nickvergessen@MorrisJobke