Skip to content

Fixed email form on new user - #8587

Merged
rullzer merged 1 commit into
masterfrom
email-to-new-user-fix
Mar 1, 2018
Merged

Fixed email form on new user#8587
rullzer merged 1 commit into
masterfrom
email-to-new-user-fix

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

Fix bug where the email in a user creation was always sent blank to the server.
Also fixes#6468

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
autocomplete="off" autocapitalize="none" autocorrect="off" />
</td>
<td class="password">
<input id="newuserpassword" type="password" required

@skjnldsvskjnldsvFeb 28, 2018

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not required, already handled by server and generated if email is valid

if ($password === '') {
if ($email === '') {
returnnewDataResponse(
[
'message' => (string)$this->l10n->t('To send a password link to the user an email address is required.')
],
Http::STATUS_UNPROCESSABLE_ENTITY
);
}
$password = $this->secureRandom->generate(30);
// Make sure we pass the password_policy
$password .= $this->secureRandom->generate(2, '$!.,;:-~+*[]{}()');
$generatePasswordResetToken = true;
}

@skjnldsvskjnldsv added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. labels Feb 28, 2018
@skjnldsvskjnldsv added this to the Nextcloud 14 milestone Feb 28, 2018

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 1, 2018
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Failure unrelated

@rullzer
rullzer merged commit e1e1651 into masterMar 1, 2018
@rullzer
rullzer deleted the email-to-new-user-fix branch March 1, 2018 19:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishdesignDesign, UI, UX, etc.enhancementpapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User management: Show email column by default and also send email to new users

3 participants

@skjnldsv@rullzer@juliusknorr