Skip to content

Ellipsize long values in the user management - #8605

Merged
rullzer merged 1 commit into
masterfrom
user-page-ellipsize
Mar 1, 2018
Merged

Ellipsize long values in the user management#8605
rullzer merged 1 commit into
masterfrom
user-page-ellipsize

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Mar 1, 2018

Copy link
Copy Markdown
Member

This will properly limit the size of the text for username, displayname and email.

Found when reviewing #8587
Before:
peek 2018-03-01 17-04

After:
peek 2018-03-01 16-59

@juliusknorrjuliusknorr added bug 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. feature: users and groups labels Mar 1, 2018
@juliusknorrjuliusknorr added this to the Nextcloud 14 milestone Mar 1, 2018

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair!

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer
rullzerforce-pushed the user-page-ellipsize branch from c9ca0bf to c820ee8CompareMarch 1, 2018 19:17
@codecov

codecovBot commented Mar 1, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8605 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #8605 +/- ##
============================================
+ Coverage 51.86% 51.89% +0.02% - Complexity 25418 25478 +60 
============================================
Files 1609 1609 Lines 95329 95408 +79 Branches 1378 1378 ============================================
+ Hits 49446 49512 +66 - Misses 45883 45896 +13
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Storage/Common.php56.58% <0%> (-12.63%)207% <0%> (+60%)
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
lib/private/Files/ObjectStore/SwiftFactory.php56.32% <0%> (+56.32%)35% <0%> (ø)⬇️
lib/private/Files/ObjectStore/Swift.php75% <0%> (+75%)8% <0%> (ø)⬇️

@skjnldsvskjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 1, 2018
@rullzer
rullzer merged commit e8f9257 into masterMar 1, 2018
@rullzer
rullzer deleted the user-page-ellipsize branch March 1, 2018 20:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews4. to releaseReady to be released and/or waiting for tests to finishbugfeature: users and groupspapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@rullzer@skjnldsv