Uh oh!
There was an error while loading. Please reload this page.
Check if the cached js file exists - #8714
Merged
Merged
Conversation
Fixes#8705 If the file does not exist (for whatever reason). It is never cached. No matter what the depscache etc tell you. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
requested review from
MorrisJobke, juliusknorr, nickvergessen and skjnldsvMarch 7, 2018 11:56
skjnldsv
approved these changes
Mar 7, 2018
skjnldsv
left a comment
Member
There was a problem hiding this comment.
Yes, I had issues with this before!
MorrisJobke
approved these changes
Mar 7, 2018
MorrisJobke
commented
Mar 7, 2018
Member
Tests fail. |
Codecov Report
@@ Coverage Diff @@## master #8714 +/- ##
============================================
- Coverage 51.87% 51.87% -0.01% - Complexity 25367 25368 +1
============================================
Files 1607 1607 Lines 95154 95157 +3 Branches 1379 1379 ============================================
Hits 49362 49362 - Misses 45792 45795 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#8705
If the file does not exist (for whatever reason). It is never cached. No
matter what the depscache etc tell you.
@MorrisJobke please double check but I think this should do the trick.