Skip to content

[stable13] Check if the cached js file exists - #8746

Merged
juliusknorr merged 2 commits into
stable13from
8705_13
Mar 9, 2018
Merged

[stable13] Check if the cached js file exists#8746
juliusknorr merged 2 commits into
stable13from
8705_13

Conversation

@rullzer

Copy link
Copy Markdown
Member

backport #8714

Fixes#8705
If the file does not exist (for whatever reason). It is never cached. No
matter what the depscache etc tell you.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Mar 9, 2018
@rullzerrullzer added this to the Nextcloud 13.0.1 milestone Mar 9, 2018
@MorrisJobkeMorrisJobke mentioned this pull request Mar 9, 2018
10 tasks
@codecov

codecovBot commented Mar 9, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8746 into stable13 will decrease coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable13 #8746 +/- ##
=============================================
- Coverage 51.3% 51.3% -0.01% - Complexity 25017 25018 +1 
=============================================
Files 1609 1609 Lines 95285 95288 +3 Branches 1376 1376 =============================================
+ Hits 48882 48883 +1 - Misses 46403 46405 +2
Impacted FilesCoverage ΔComplexity Δ
lib/private/Template/JSCombiner.php87.5% <100%> (-1.61%)31 <0> (+1)

@juliusknorr
juliusknorr merged commit e2728aa into stable13Mar 9, 2018
@juliusknorr
juliusknorr deleted the 8705_13 branch March 9, 2018 09:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@juliusknorr@skjnldsv