Skip to content

Remove old code to be compatible with Nextcloud 9 and before - #8781

Merged
MorrisJobke merged 1 commit into
masterfrom
cleanup-old-federation-code
Mar 13, 2018
Merged

Remove old code to be compatible with Nextcloud 9 and before#8781
MorrisJobke merged 1 commit into
masterfrom
cleanup-old-federation-code

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Mar 12, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Even 10 is already EoL

cc @nextcloud/sharing @nickvergessen@blizzz

Ref #8375

@MorrisJobke
Remove old code to be compatible with Nextcloud 9 and before
4cbcf6f
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Mar 12, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Mar 12, 2018
ChristophWurst
ChristophWurst approved these changes Mar 12, 2018
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me 🔥

@rullzer

rullzer commented Mar 13, 2018

Copy link
Copy Markdown
Member

Ah well. In principal I'm fine. But this does mean that you might not be able to mount shares of other people. You can't control their instance.

@schiessle what is your take on this.

@MorrisJobke

MorrisJobke commented Mar 13, 2018

Copy link
Copy Markdown
MemberAuthor

Ah well. In principal I'm fine. But this does mean that you might not be able to mount shares of other people. You can't control their instance.

Sure, but at some point we need to drop support for old instances. And let's hope that there are no instances with 9 out there that want to federate with 14 ...

@MorrisJobke

MorrisJobke commented Mar 13, 2018

Copy link
Copy Markdown
MemberAuthor

Sure, but at some point we need to drop support for old instances. And let's hope that there are no instances with 9 out there that want to federate with 14 ...

In other words: the code on those instances might have security issues, that we only fixed in 10+ because of the EoL state.

@MorrisJobke
MorrisJobke merged commit 58599e0 into masterMar 13, 2018
@MorrisJobke
MorrisJobke deleted the cleanup-old-federation-code branch March 13, 2018 10:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@MariusBluemMariusBluemMariusBluem approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@schiessleschiessleAwaiting requested review from schiessle
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@rullzer@ChristophWurst@MariusBluem