Uh oh!
There was an error while loading. Please reload this page.
Make phan config more strict - #8375
Closed
MorrisJobke wants to merge 1 commit into
Closed
Conversation
MorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
2 times, most recently
from
March 7, 2018 10:43
3fbc39a to
9f01041CompareMemberAuthor
Rebased and resolved quite some stuff to make it a bit easier to dive through them: Before: After: |
MorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
3 times, most recently
from
March 7, 2018 10:55
f0d23ee to
5ef467bComparerullzer
commented
Mar 9, 2018
Member
Wow seems we did good :) |
MemberAuthor
2018-03-09: 1814 warnings to go xD |
Merged
MorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
from
March 12, 2018 13:00
5ef467b to
6f03948Compare
This was referenced Mar 12, 2018
This was referenced Mar 12, 2018
MorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
3 times, most recently
from
March 12, 2018 16:06
86e20dc to
d8b659bCompare
This was referenced Mar 12, 2018
MorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
from
March 13, 2018 10:07
d8b659b to
63490b0CompareMorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
from
March 21, 2018 13:40
63490b0 to
365b488CompareMorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
from
March 22, 2018 08:59
365b488 to
3eb36b3CompareCodecov Report
@@ Coverage Diff @@## master #8375 +/- ##
=========================================
Coverage ? 51.93% Complexity ? 25388 =========================================
Files ? 1608 Lines ? 95440 Branches ? 1394 =========================================
Hits ? 49564 Misses ? 45876 Partials ? 0 |
MorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
from
April 19, 2018 12:38
3eb36b3 to
9649aa3CompareMorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
from
April 23, 2018 08:37
9649aa3 to
58a348bCompareMorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
2 times, most recently
from
April 23, 2018 14:03
c251ead to
e25e963Compare Merged
MorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
from
April 26, 2018 12:11
e25e963 to
88487c6Compare
This was referenced Apr 26, 2018
MorrisJobke
commented
Apr 26, 2018
| // critical issues is a good place to start on a big | ||
| // sloppy mature code base. | ||
| 'minimum_severity' => \Phan\Issue::SEVERITY_CRITICAL, | ||
| 'minimum_severity' => \Phan\Issue::SEVERITY_NORMAL, |
MemberAuthor
There was a problem hiding this comment.
Okay this causes ~1200 warnings -> let's do this later
MorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
from
April 26, 2018 13:30
88487c6 to
068097bCompare* fix ocs/ and remote.php * ignore some more templates of apps Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
MorrisJobkeforce-pushed
the
make-phan-config-more-strict
branch
from
May 23, 2018 17:56
068097b to
99e32e1CompareMorrisJobke
commented
Jun 29, 2018
MemberAuthor
Not the way to go -> closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder for myself to take this and get it step by step in.
cc @rullzer