Skip to content

Use proper method to format absolute timestamp - #8782

Merged
MorrisJobke merged 1 commit into
masterfrom
properly-use-new-method-to-format-date
Mar 12, 2018
Merged

Use proper method to format absolute timestamp#8782
MorrisJobke merged 1 commit into
masterfrom
properly-use-new-method-to-format-date

Conversation

@MorrisJobke

@MorrisJobkeMorrisJobke commented Mar 12, 2018

Copy link
Copy Markdown
Member

Ref #8375

@MorrisJobkeMorrisJobke added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Mar 12, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Mar 12, 2018
skjnldsv
skjnldsv approved these changes Mar 12, 2018
View reviewed changes

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense

@MorrisJobke
Use proper method to format absolute timestamp
44289ff
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke
MorrisJobkeforce-pushed the properly-use-new-method-to-format-date branch from cb805f5 to 44289ffCompareMarch 12, 2018 14:16
@codecov

codecovBot commented Mar 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8782 into master will decrease coverage by 20.49%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #8782 +/- ##
============================================
- Coverage 51.87% 31.37% -20.5% + Complexity 25380 25376 -4 
============================================
Files 1608 1608 Lines 95157 95151 -6 Branches 1377 1377 ============================================
- Hits 49366 29858 -19508 - Misses 45791 65293 +19502
Impacted FilesCoverage ΔComplexity Δ
lib/private/legacy/util.php25.74% <ø> (-33.04%)240 <0> (-4)
settings/templates/settings/admin/server.php0% <0%> (ø)0 <0> (ø)⬇️
lib/private/TagManager.php0% <0%> (-100%)4% <0%> (ø)
apps/user_ldap/lib/LDAPUtility.php0% <0%> (-100%)1% <0%> (ø)
...s/dav/lib/Connector/Sabre/Exception/FileLocked.php0% <0%> (-100%)3% <0%> (ø)
lib/private/Share20/Hooks.php0% <0%> (-100%)3% <0%> (ø)
lib/private/Files/Mount/CacheMountProvider.php0% <0%> (-100%)4% <0%> (ø)
lib/private/Accounts/Hooks.php0% <0%> (-100%)14% <0%> (ø)
...public/AppFramework/OCS/OCSBadRequestException.php0% <0%> (-100%)1% <0%> (ø)
...yBuilder/FunctionBuilder/SqliteFunctionBuilder.php0% <0%> (-100%)1% <0%> (ø)
... and 374 more

@MorrisJobke
MorrisJobke merged commit 3df2fb7 into masterMar 12, 2018
@MorrisJobke
MorrisJobke deleted the properly-use-new-method-to-format-date branch March 12, 2018 15:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzerrullzerrullzer approved these changes
@nickvergessennickvergessennickvergessen approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@ChristophWurstChristophWurstAwaiting requested review from ChristophWurst

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewstechnical debt🧱 🤔🚀

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke@rullzer@nickvergessen@skjnldsv