Uh oh!
There was an error while loading. Please reload this page.
Use insertIfNotExist of the new interface - #8786
Merged
Merged
Conversation
MorrisJobke
requested review from
ChristophWurst, nickvergessen, rullzer and skjnldsvMarch 12, 2018 14:11
rullzer
approved these changes
Mar 12, 2018
| $this->assertGreaterThan($id1, $id2); | ||
| } | ||
| public function testinsertIfNotExist() { |
There was a problem hiding this comment.
are there tests for the connection version of it?
MemberAuthor
There was a problem hiding this comment.
What do you mean by this?
There was a problem hiding this comment.
I wondered if IDBConnection::insertIfNotExist() has tests
MemberAuthor
There was a problem hiding this comment.
I couldn't find one ... let me then migrate those tests over to the IDBConnection.
MemberAuthor
There was a problem hiding this comment.
Migrated them to the new class.
nickvergessen
approved these changes
Mar 12, 2018
nickvergessen
commented
Mar 12, 2018
Member
Conflicting files |
MorrisJobkeforce-pushed
the
remove-insert-if-not-exists
branch
from
March 12, 2018 15:36
aa8cc6f to
2b849ebCompareCodecov Report
@@ Coverage Diff @@## master #8786 +/- ##
============================================
- Coverage 51.87% 31.4% -20.48% + Complexity 25358 25357 -1
============================================
Files 1607 1607 Lines 95101 95100 -1 Branches 1377 1377 ============================================
- Hits 49336 29863 -19473 - Misses 45765 65237 +19472
|
MorrisJobke
commented
Mar 12, 2018
MemberAuthor
Already fixed :P |
MorrisJobkeforce-pushed
the
remove-insert-if-not-exists
branch
2 times, most recently
from
March 12, 2018 16:03
e7de9c0 to
a49d8a7Compareskjnldsv
approved these changes
Mar 12, 2018
MorrisJobkeforce-pushed
the
remove-insert-if-not-exists
branch
from
March 12, 2018 16:30
a49d8a7 to
8d3104aCompareSigned-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobkeforce-pushed
the
remove-insert-if-not-exists
branch
from
March 12, 2018 16:45
8d3104a to
2b335fdCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #8375