Uh oh!
There was an error while loading. Please reload this page.
Remove unused methods of OC_Response - #8792
Merged
Merged
Conversation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
ChristophWurst, nickvergessen, rullzer and skjnldsvMarch 12, 2018 17:43
ChristophWurst
requested changes
Mar 12, 2018
| if($token !== '') { | ||
| OC_Response::redirect($urlGenerator->linkToRoute($route, array('token' => $token))); | ||
| $protocol = \OC::$server->getRequest()->getHttpProtocol(); | ||
| if ($protocol == 'HTTP/1.1') { |
MemberAuthor
There was a problem hiding this comment.
Just a copy paste and should be replaced soon anyways.
ChristophWurst
approved these changes
Mar 12, 2018
| if ($protocol == 'HTTP/1.1') { | ||
| $status = '307 Temporary Redirect'; | ||
| } else { | ||
| $status = '304 Found'; |
Member
There was a problem hiding this comment.
304 Not Modified is the proper code?
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Codecov Report
@@ Coverage Diff @@## master #8792 +/- ##
============================================
- Coverage 51.87% 51.81% -0.06% - Complexity 25358 25379 +21
============================================
Files 1607 1607 Lines 95101 95087 -14 Branches 1377 1377 ============================================
- Hits 49336 49272 -64 - Misses 45765 45815 +50
|
MorrisJobke
commented
Mar 13, 2018
MemberAuthor
Thanks @skjnldsv was wrong status code in the initial code. I also fixed the HTTP/1.0 detection ;) |
rullzer
commented
Mar 13, 2018
Member
HTTP 1.0 support needs to die anyway. 1.1 was release in 1997 |
rullzer
approved these changes
Mar 13, 2018
skjnldsv
commented
Mar 13, 2018
Member
Cant we return HTTP 418 instead? :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #8375 and #7827