Skip to content

Allow empty emails provisioning api - #8864

Merged
rullzer merged 1 commit into
masterfrom
ocs-allow-empty-email-displayname
Mar 20, 2018
Merged

Allow empty emails provisioning api#8864
rullzer merged 1 commit into
masterfrom
ocs-allow-empty-email-displayname

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Mar 17, 2018

Copy link
Copy Markdown
Member

Handled by the server but not implemented in the api:
https://github.com/nextcloud/server/blob/master/lib/private/User/User.php#L162-L172

Required by #8824

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. labels Mar 17, 2018
@skjnldsvskjnldsv self-assigned this Mar 17, 2018
@skjnldsvskjnldsv added this to the Nextcloud 14 milestone Mar 17, 2018
@skjnldsvskjnldsv mentioned this pull request Mar 17, 2018
34 tasks
@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Failure unrelated

@MorrisJobke

Copy link
Copy Markdown
Member

Handled by the server but not implemented in the api:

Isn't this needed to delete the email address of a user via API?

@skjnldsv

Copy link
Copy Markdown
MemberAuthor

Isn't this needed to delete the email address of a user via API?

Yes it is, but there was a preventive check for empty values, so you couldn't send any empty data :)

@rullzer
rullzer merged commit 99abe3b into masterMar 20, 2018
@rullzer
rullzer deleted the ocs-allow-empty-email-displayname branch March 20, 2018 08:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewspapercutAnnoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@MorrisJobke@rullzer@blizzz