Vue migration: settings

[skjnldsv]

Features:

• Form validation
  • New user form requires user+pass or user+email minimum
  • Validate every other fields:
    • displayname can be empty
    • password can't be empty and has the minlength requirement from the password policy if enabled
    • emails are validated as emails & can be empty
• We switched to a grid design, no more ugly table
• Hide/show columns settings are now saved in the browser, saving us some undesirable db entries
• Only using our api, no more shady legacy ajax entry points
• We only show 2 groups max, and add an indicator saying how many more are selected (better visual & consistency)
• Password can't be change if encryption does NOT use a master key (safety reason)
• Now using Vuejs, components are fresh and will be moved to a dedicated repo later on with proper documentation and tests
• Language edition capability

Fix#642
Fix#7424
Fix#5752
Fix#5751
Fix#8862
Fix#9289
Fix#9191
Fix#8917
Fix#8010
Fix#4320

Settings

• Design + base
• Quota
• Groups management
• Subadmins management
• User disablement
• User deletion
• Props edition (email, name...)
• Server-side-ecrptn password change
• Migrate to OCS api
• Support password policy min length
• Search support
• Group deletion

Design

• Better display of overflow tags
• Themed vue-multiselect

Waiting for:

• Allow admin to create users without password by sending mail automatic… #8856
• Add userdetails to ocs api #8847
• Allow empty emails provisioning api #8864
• Return groups displayname in provisioning api #8865
• Api: return users details by groups #8904
• Return quota even if user is not initialised #8926
• Return proper boolean and do not save enabled state in db #9111
• Various css fixes #8777
• Allow user creation with subadmins and quota #9108
• Migrate groups fetch to ocs api #9296
• Added firefox profile option to acceptance tests with selenium and behat #9438

Components see #7738

• Popovermenu v1
• AppNavigation v1
• Request api + authentification system

Bugs

• On user deletion, if admin of group(s), db key(s) is/are not removed
• All user count also includes disabled but they are not shown on the list
• User old apppassword are not deleted on user deletion! ⚠️

Before merge:

• Drop css fixed commits after Various css fixes #8777
• Drop 582aece after Allow user creation with subadmins and quota #9108 is merged
• Drop a361b7b after Return proper boolean and do not save enabled state in db #9111 is merged

[codecov]

Codecov Report

Merging #8824 into master will increase coverage by 0.01%.
The diff coverage is 22.94%.

@@ Coverage Diff @@## master #8824 +/- ##
============================================
+ Coverage 51.7% 51.71% +0.01% + Complexity 25742 25671 -71 
============================================
Files 1643 1634 -9 Lines 96501 95810 -691 Branches 1393 1381 -12 ============================================
- Hits 49895 49550 -345 + Misses 46606 46260 -346

Impacted Files	Coverage Δ	Complexity Δ
lib/private/NavigationManager.php	77.55% <0%> (ø)	51 <0> (ø)	⬇️
settings/templates/settings.php	0% <0%> (ø)	0 <0> (ø)	⬇️
settings/routes.php	0% <0%> (ø)	0 <0> (ø)	⬇️
lib/private/Settings/Personal/PersonalInfo.php	0% <0%> (ø)	16 <0> (-14)	⬇️
settings/Controller/UsersController.php	41.96% <30.76%> (-26.95%)	39 <22> (-81)
lib/private/L10N/Factory.php	60.82% <8.82%> (-11.57%)	88 <16> (+16)
settings/Application.php	50% <0%> (-20.69%)	14% <0%> (ø)
lib/private/Group/MetaData.php	71.62% <0%> (-5.41%)	19% <0%> (ø)
lib/private/LargeFileHelper.php	60.29% <0%> (-4.79%)	28% <0%> (+2%)
lib/private/Files/Cache/Propagator.php	94.93% <0%> (-1.27%)	16% <0%> (ø)
... and 6 more

[skjnldsv]

@nextcloud/designers bump :)

[skjnldsv]

@michag86 small push to update the width of the groups list
Also: added a tooltip to show the full list on hover:

[MorrisJobke]

Tested and works a lot better than before - some minor things for Edge and IE, but this is stuff for later 👍

[rullzer]

🐘

[danopz]

Will the components be pushed to nextcloud/vue-components?

[skjnldsv]

@danopz very soon yes :)