Uh oh!
There was an error while loading. Please reload this page.
Use app version to generate scss filename - #8999
Merged
Merged
Conversation
juliusknorr
previously requested changes
Mar 27, 2018
| public function getCachedCSS(string $appName, string $fileName): ISimpleFile { | ||
| $folder = $this->appData->getFolder($appName); | ||
| return $folder->getFile($this->prependBaseurlPrefix($fileName)); | ||
| $cachedFileName = $this->prependVersionPrefix($this->prependBaseurlPrefix($fileName), $appName); |
Member
There was a problem hiding this comment.
Looks like $folder->getFile() has been lost
MemberAuthor
There was a problem hiding this comment.
Nice catch. Somehow missed that! 🙈
| * @param string $appId | ||
| * @return string | ||
| */ | ||
| private function prependVersionPrefix(string $cssFile, string $appId): string { |
Member
There was a problem hiding this comment.
Any specific reason to not just have one prependPrefix method?
skjnldsvforce-pushed
the
css-js-name-based-on-apps-versions
branch
from
March 27, 2018 20:03
feb1784 to
7ebb686CompareCodecov Report
@@ Coverage Diff @@## master #8999 +/- ##
=============================================
- Coverage 51.96% 35.03% -16.93% - Complexity 25278 25283 +5
=============================================
Files 1601 1601 Lines 94950 94965 +15 Branches 1388 1388 =============================================
- Hits 49342 33273 -16069 - Misses 45608 61692 +16084
|
Fixed scsscacher tests Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsvforce-pushed
the
css-js-name-based-on-apps-versions
branch
from
March 28, 2018 06:34
7ebb686 to
1d7b14dCompareskjnldsv
commented
Mar 28, 2018
MemberAuthor
Fixed tests |
juliusknorr
approved these changes
Mar 28, 2018
juliusknorr
left a comment
Member
There was a problem hiding this comment.
Looks good and works as expected.
| * @param string $appId | ||
| * @return string | ||
| */ | ||
| private function prependVersionPrefix(string $cssFile, string $appId): string { |
rullzer
approved these changes
Mar 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To force our scss cache to clear