Skip to content

[stable13] Use app version to generate scss filename - #9015

Merged
MorrisJobke merged 1 commit into
stable13from
backport-apps-versions
Apr 3, 2018
Merged

[stable13] Use app version to generate scss filename#9015
MorrisJobke merged 1 commit into
stable13from
backport-apps-versions

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Mar 28, 2018•
edited
Loading

Copy link
Copy Markdown
Member

backport #8999

@skjnldsv
Use app version to generate scss filename
05f76b3
Fixed scsscacher tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added this to the Nextcloud 13.0.2 milestone Mar 28, 2018
@skjnldsvskjnldsv self-assigned this Mar 28, 2018
@skjnldsvskjnldsv changed the title [stable13] Use app version to generate scss filename #8999[stable13] Use app version to generate scss filenameMar 28, 2018
@kyrofa

kyrofa commented Mar 28, 2018

Copy link
Copy Markdown
Member

This one I'm able to test! Unfortunately, when snapped and using a datadirectory in /media, the CSS cache still doesn't look right after upgrade from 12 to this PR:

image

@codecov

codecovBot commented Mar 28, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9015 into stable13 will increase coverage by <.01%.
The diff coverage is 83.33%.

@@ Coverage Diff @@## stable13 #9015 +/- ##
==============================================
+ Coverage 51.33% 51.34% +<.01% - Complexity 25027 25029 +2 
==============================================
Files 1609 1609 Lines 95298 95305 +7 Branches 1376 1376 ==============================================
+ Hits 48922 48931 +9 + Misses 46376 46374 -2
Impacted FilesCoverage ΔComplexity Δ
lib/private/Template/SCSSCacher.php72.41% <83.33%> (+0.67%)38 <2> (+2)⬆️
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️
apps/files_trashbin/lib/Expiration.php91.93% <0%> (+1.61%)29% <0%> (ø)⬇️

kyrofa
kyrofa approved these changes Mar 28, 2018
View reviewed changes

@kyrofakyrofa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the issue I was hoping it would, but it doesn't regress behavior and is a positive change. +1 from me, thank you!

@MorrisJobke
MorrisJobke merged commit 7bb8ce0 into stable13Apr 3, 2018
@MorrisJobke
MorrisJobke deleted the backport-apps-versions branch April 3, 2018 08:28
@MorrisJobkeMorrisJobke mentioned this pull request Apr 18, 2018
Merged
11 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@kyrofakyrofakyrofa approved these changes
@rullzerrullzerAwaiting requested review from rullzer
@LukasReschkeLukasReschkeAwaiting requested review from LukasReschke
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

@skjnldsvskjnldsv

Labels

3. to reviewWaiting for reviewsbugfeature: scsshigh

Projects

None yet

Milestone

Nextcloud 13.0.2

Development

Successfully merging this pull request may close these issues.

3 participants

@skjnldsv@kyrofa@MorrisJobke