Skip to content

Fix undefined variable - found by Phan - #9271

Merged
nickvergessen merged 3 commits into
masterfrom
fix-undefined-variable
Apr 23, 2018
Merged

Fix undefined variable - found by Phan#9271
nickvergessen merged 3 commits into
masterfrom
fix-undefined-variable

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Added in #2744

Found by Phan (#8375):

lib/private/Files/Storage/DAV.php:773 PhanUndeclaredVariable Variable $e is undeclared

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Left over from a refactoring
#1940
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@codecov

codecovBot commented Apr 23, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9271 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

@@ Coverage Diff @@## master #9271 +/- ##
============================================
- Coverage 51.95% 51.95% -0.01% + Complexity 25375 25373 -2 
============================================
Files 1607 1607 Lines 95393 95392 -1 Branches 1394 1394 ============================================
- Hits 49559 49557 -2 - Misses 45834 45835 +1
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Storage/DAV.php65.18% <0%> (ø)159 <0> (ø)⬇️
lib/private/Files/ObjectStore/SwiftFactory.php0% <0%> (ø)37 <0> (ø)⬇️
lib/private/Installer.php58.39% <100%> (-0.16%)71 <0> (-2)
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)

@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Added another leftover from a refactoring: #1940

@nickvergessen
nickvergessen merged commit 05a6b71 into masterApr 23, 2018
@nickvergessen
nickvergessen deleted the fix-undefined-variable branch April 23, 2018 13:51
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

Backport in #9651

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@nickvergessen@icewind1991