Skip to content

Migrate groups fetch to ocs api - #9296

Merged
MorrisJobke merged 2 commits into
masterfrom
migrate-groups-fetch-to-ocs-api
Apr 25, 2018
Merged

Migrate groups fetch to ocs api#9296
MorrisJobke merged 2 commits into
masterfrom
migrate-groups-fetch-to-ocs-api

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Apr 25, 2018

Copy link
Copy Markdown
Member

Use our ocs api instead of old group controller legacy in settings

I reformatted the files:
the only real change is:
https://github.com/nextcloud/server/pull/9296/files?w=1

$.ajax({url: OC.linkToOCS('cloud/groups',2)+'details',dataType: 'json',success: function(data){varresults=[];if(data.ocs.data.groups&&data.ocs.data.groups.length>0){data.ocs.data.groups.forEach(function(group){if(!options.excludeAdmins||group.id!=='admin'){results.push({id: group.id,displayname: group.displayname});}})

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@codecov

codecovBot commented Apr 25, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9296 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #9296 +/- ##
============================================
+ Coverage 51.93% 51.93% +<.01% 
Complexity 25389 25389 ============================================
Files 1608 1608 Lines 95436 95436 Branches 1394 1394 ============================================
+ Hits 49563 49564 +1 + Misses 45873 45872 -1
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@rullzerrullzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean the old endpoint can die?

@nickvergessen

Copy link
Copy Markdown
Member

It does with #8824

@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 25, 2018
@MorrisJobke
MorrisJobke merged commit 5a4a0ad into masterApr 25, 2018
@MorrisJobke
MorrisJobke deleted the migrate-groups-fetch-to-ocs-api branch April 25, 2018 11:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishfeature: settingsfeature: users and groups

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@skjnldsv@nickvergessen@rullzer@MorrisJobke