Uh oh!
There was an error while loading. Please reload this page.
Improve phan config - #9302
Merged
Merged
Conversation
MorrisJobke
requested review from
ChristophWurst, nickvergessen, rullzer and skjnldsvApril 25, 2018 13:53
Codecov Report
@@ Coverage Diff @@## master #9302 +/- ##
============================================
+ Coverage 51.92% 51.93% +<.01%
Complexity 25388 25388 ============================================
Files 1608 1608 Lines 95429 95429 Branches 1394 1394 ============================================
+ Hits 49555 49559 +4 + Misses 45874 45870 -4
|
| 'apps/comments/composer', | ||
| 'apps/comments/tests', | ||
| 'apps/dav/composer', | ||
| 'apps/dav/templates', |
There was a problem hiding this comment.
Hmm this caught php errors in templates, any reason to exclude them?
MemberAuthor
There was a problem hiding this comment.
Because there are many undefined variables from phan‘s point of view :/
MemberAuthor
There was a problem hiding this comment.
Let's drop this for now and get the remaining stuff in.
rullzer
approved these changes
Apr 26, 2018
* exclude routes Signed-off-by: Lukas Reschke <lukas@statuscode.ch> Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobkeforce-pushed
the
update-phan-config
branch
from
April 26, 2018 09:51
ba7f4f8 to
3aaa230CompareMorrisJobke
commented
Apr 26, 2018
MemberAuthor
@nickvergessen Please re-review ;) |
nickvergessen
approved these changes
Apr 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8375 to get it in in smaller steps