Skip to content

Check doc block signature to match the specified return type - #9313

Merged
MorrisJobke merged 1 commit into
masterfrom
phan-check-php-doc
May 7, 2018
Merged

Check doc block signature to match the specified return type#9313
MorrisJobke merged 1 commit into
masterfrom
phan-check-php-doc

Conversation

@MorrisJobke

Copy link
Copy Markdown
Member

Extracted from #8375

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke added the 2. developing Work in progress label Apr 26, 2018
@MorrisJobkeMorrisJobke added this to the Nextcloud 14 milestone Apr 26, 2018
@rullzer

Copy link
Copy Markdown
Member

@rullzerrullzer added 3. to review Waiting for reviews enhancement and removed 2. developing Work in progress labels Apr 26, 2018
@MorrisJobke

Copy link
Copy Markdown
MemberAuthor

I guess it only likes it because it is logged as normal and not aas critical problem. :/

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 on having that checked

@MorrisJobke
MorrisJobke merged commit 6d5f443 into masterMay 7, 2018
@MorrisJobke
MorrisJobke deleted the phan-check-php-doc branch May 7, 2018 13:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@MorrisJobke@rullzer@ChristophWurst