Skip to content

[stable13] Replace deprecated sinon reset() call with resetHistory() - #9358

Merged
rullzer merged 1 commit into
stable13from
stable13-9348
May 2, 2018
Merged

[stable13] Replace deprecated sinon reset() call with resetHistory()#9358
rullzer merged 1 commit into
stable13from
stable13-9348

Conversation

@juliusknorr

Copy link
Copy Markdown
Member

backport of #9348 to fix the failing jsunit tests

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@MorrisJobkeMorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 2, 2018
@codecov

codecovBot commented May 2, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9358 into stable13 will increase coverage by 0.51%.
The diff coverage is n/a.

@@ Coverage Diff @@## stable13 #9358 +/- ##
==============================================
+ Coverage 50.84% 51.36% +0.51% 
Complexity 25047 25047 ==============================================
Files 1544 1609 +65 Lines 87532 95333 +7801 Branches 0 1376 +1376 ==============================================
+ Hits 44508 48966 +4458 - Misses 43024 46367 +3343
Impacted FilesCoverage ΔComplexity Δ
apps/comments/js/commentstabview.js84.25% <0%> (ø)0% <0%> (?)
core/js/sharedialogview.js75.43% <0%> (ø)0% <0%> (?)
apps/files_external/js/app.js15.9% <0%> (ø)0% <0%> (?)
core/js/systemtags/systemtags.js100% <0%> (ø)0% <0%> (?)
settings/js/apps.js24.39% <0%> (ø)0% <0%> (?)
core/js/systemtags/systemtagmodel.js100% <0%> (ø)0% <0%> (?)
core/js/systemtags/systemtagsinputfield.js82.79% <0%> (ø)0% <0%> (?)
core/js/setupchecks.js96.29% <0%> (ø)0% <0%> (?)
apps/systemtags/js/app.js15.55% <0%> (ø)0% <0%> (?)
apps/comments/js/commentcollection.js90.9% <0%> (ø)0% <0%> (?)
... and 55 more

@rullzer
rullzer merged commit 9763e7d into stable13May 2, 2018
@rullzer
rullzer deleted the stable13-9348 branch May 2, 2018 08:09
@MorrisJobkeMorrisJobke mentioned this pull request May 31, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to releaseReady to be released and/or waiting for tests to finishbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@juliusknorr@rullzer@MorrisJobke