Skip to content

Added firefox profile option to acceptance tests with selenium and behat - #9438

Closed
skjnldsv wants to merge 1 commit into
masterfrom
added-css-grid-and-firefox-profile-tests
Closed

Added firefox profile option to acceptance tests with selenium and behat#9438
skjnldsv wants to merge 1 commit into
masterfrom
added-css-grid-and-firefox-profile-tests

Conversation

@skjnldsv

Copy link
Copy Markdown
Member

@skjnldsvskjnldsv added enhancement 3. to review Waiting for reviews labels May 9, 2018
@skjnldsvskjnldsv added this to the Nextcloud 14 milestone May 9, 2018
@skjnldsvskjnldsv self-assigned this May 9, 2018
@skjnldsv
skjnldsv requested a review from danxuliuMay 9, 2018 17:55
@codecov

codecovBot commented May 9, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9438 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@## master #9438 +/- ##
============================================
+ Coverage 51.61% 51.61% +<.01% + Complexity 25694 25684 -10 
============================================
Files 1638 1638 Lines 96315 96283 -32 Branches 1393 1393 ============================================
- Hits 49713 49697 -16 + Misses 46602 46586 -16
Impacted FilesCoverage ΔComplexity Δ
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php72.7% <0%> (+0.24%)136% <0%> (ø)⬇️
lib/private/legacy/api.php35.41% <0%> (+1.04%)31% <0%> (ø)⬇️
lib/private/AppFramework/OCS/BaseResponse.php80.76% <0%> (+4.9%)4% <0%> (-10%)⬇️
lib/private/legacy/json.php12% <0%> (+12%)19% <0%> (ø)⬇️

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv
skjnldsvforce-pushed the added-css-grid-and-firefox-profile-tests branch from 6bf6253 to 0d72d6bCompareMay 10, 2018 05:51
@skjnldsvskjnldsv mentioned this pull request May 10, 2018
34 tasks
@skjnldsvskjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 14, 2018
@danxuliu

Copy link
Copy Markdown
Member

Overriden by #9521

I created a different pull request instead of amending this one to leave it as future reference, just in case this technique is needed later. In any case note that currently this technique works only for acceptance tests run in local, but not for those run in Drone.

@danxuliu
danxuliu deleted the added-css-grid-and-firefox-profile-tests branch May 18, 2018 12:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progressenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@skjnldsv@danxuliu