Uh oh!
There was an error while loading. Please reload this page.
[stable13] Improve OAuth - #9540
Merged
Merged
Conversation
This for example will allow rotating the apptoken for oauth Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
backport/9517/stable13
branch
from
May 22, 2018 10:51
2214708 to
8fcb7d4CompareCodecov Report
@@ Coverage Diff @@## stable13 #9540 +/- ##
=============================================
+ Coverage 51.38% 51.4% +0.01% - Complexity 25052 25081 +29
=============================================
Files 1609 1612 +3 Lines 95350 95457 +107 Branches 1376 1376 =============================================
+ Hits 48999 49066 +67 - Misses 46351 46391 +40
|
rullzerforce-pushed
the
backport/9517/stable13
branch
3 times, most recently
from
May 22, 2018 12:20
a70250d to
710f0ddCompareHowever due to the nature of what we store in the token (encrypted passwords etc). We can't just delete the tokens because that would make the oauth refresh useless. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
backport/9517/stable13
branch
from
May 22, 2018 12:26
710f0dd to
46aafe4CompareSigned-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
On a refresh token request: * rorate * reset expire Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
ChristophWurst
approved these changes
May 23, 2018
| { | ||
| public static $firstCharsPsr4 = array ( | ||
| 'O' => true, | ||
| public static $prefixLengthsPsr4 = array ( |
MemberAuthor
There was a problem hiding this comment.
Because I had to rerun the autoload dump. And I guess there is a new composer version ;)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: