Uh oh!
There was an error while loading. Please reload this page.
Improve OAuth handling - #9517
Merged
Merged
Conversation
blizzz
reviewed
May 18, 2018
blizzz
left a comment
Member
There was a problem hiding this comment.
cannot say much about it… but at least some bikeshedding
| public function authorize($client_id, | ||
| $state) { | ||
| $state, | ||
| $response_type) { |
MemberAuthor
There was a problem hiding this comment.
No I can't change those as they are post variables and defined in the OAuth spec
| */ | ||
| public function getToken($code) { | ||
| $accessToken = $this->accessTokenMapper->getByCode($code); | ||
| public function getToken($grant_type, $code, $refresh_token, $client_id, $client_secret) { |
MemberAuthor
There was a problem hiding this comment.
No I can't change those as they are post variables and defined in the OAuth spec
blizzz
reviewed
May 18, 2018
| // Set the 3600 second timeout on all tokens | ||
| foreach ($tokens as $token) { | ||
| try { | ||
| $appToken = $this->tokenProvider->getTokenById($token->getTokenId()); |
Member
There was a problem hiding this comment.
would it have a better memory footprint if we deal with that inside the while-loop above?
MemberAuthor
There was a problem hiding this comment.
yes fair enough let me fix that...
rullzerforce-pushed
the
feature/noid/improve_oauth_handling
branch
from
May 18, 2018 11:05
3580a75 to
a7568bcCompareCodecov Report
@@ Coverage Diff @@## master #9517 +/- ##
========================================
Coverage ? 51.7% Complexity ? 25757 ========================================
Files ? 1644 Lines ? 96569 Branches ? 1393 ========================================
Hits ? 49932 Misses ? 46637 Partials ? 0
|
blizzz
reviewed
May 18, 2018
| } | ||
| // The client id and secret must match. Else we don't provide an access token! | ||
| if ($client->getClientIdentifier() !== $client_id || $client->getSecret() !== $client_secret) { |
Member
There was a problem hiding this comment.
with grant_type = 'refresh_token' client_id and and secret are not provided. Unless I oversaw a thing? yes, i did, all right
ChristophWurst
previously requested changes
May 22, 2018
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Code looks good
Found one unused variable
| $cursor = $qb->execute(); | ||
| $tokens = []; |
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
On a refresh token request: * rorate * reset expire Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
feature/noid/improve_oauth_handling
branch
from
May 22, 2018 07:24
a7568bc to
461998dCompareChristophWurst
approved these changes
May 22, 2018
This was referenced May 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.