Uh oh!
There was an error while loading. Please reload this page.
[stable12] Improve OAuth - #9546
Merged
Merged
Conversation
rullzer
commented
May 23, 2018
MemberAuthor
I have no idea why the test fail it seems unrelated. |
ChristophWurst
approved these changes
May 23, 2018
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Looks good, I just found one spot where it could make sense to add some logging 👍
| $appToken->setExpires($this->time->getTime() + 3600); | ||
| $this->tokenProvider->updateToken($appToken); | ||
| } catch (InvalidTokenException $e) { | ||
| //Skip this token |
There was a problem hiding this comment.
Didn't see this in the original PR, but wouldn't it make sense to at least have a debug log statement for this in case we have to trace bugs in this code?
MorrisJobke
commented
May 23, 2018
Member
With this there is an endless login loop on the first authorization of an app. cc @rullzer as discussed |
This for example will allow rotating the apptoken for oauth Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
However due to the nature of what we store in the token (encrypted passwords etc). We can't just delete the tokens because that would make the oauth refresh useless. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
On a refresh token request: * rorate * reset expire Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzerforce-pushed
the
backport/9517/stable12
branch
from
May 23, 2018 15:02
884d76f to
3e57666CompareCodecov Report
@@ Coverage Diff @@## stable12 #9546 +/- ##
==============================================
+ Coverage 53.91% 53.96% +0.05% - Complexity 22786 22815 +29
==============================================
Files 1387 1389 +2 Lines 87302 87437 +135 Branches 1331 1331 ==============================================
+ Hits 47066 47185 +119 - Misses 40236 40252 +16
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of: