Skip to content

[stable13] Make the token expiration also work for autocasting 0 - #9803

Merged
skjnldsv merged 1 commit into
stable13from
backport/9802/stable13
Jun 11, 2018
Merged

[stable13] Make the token expiration also work for autocasting 0#9803
skjnldsv merged 1 commit into
stable13from
backport/9802/stable13

Conversation

@rullzer

Copy link
Copy Markdown
Member

Backport of #9802

Some bad databases don't respect the default null apprently.
Now even if they cast it to 0 it should work just fine.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Jun 8, 2018
@rullzerrullzer added this to the Nextcloud 13.0.4 milestone Jun 8, 2018
@rullzer
rullzer requested review from MorrisJobke and blizzzJune 8, 2018 14:28
@codecov

codecovBot commented Jun 8, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9803 into stable13 will increase coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## stable13 #9803 +/- ##
==============================================
+ Coverage 51.43% 51.44% +<.01% 
Complexity 25135 25135 ==============================================
Files 1613 1613 Lines 95626 95626 Branches 1376 1376 ==============================================
+ Hits 49190 49191 +1 + Misses 46436 46435 -1
Impacted FilesCoverage ΔComplexity Δ
...vate/Authentication/Token/DefaultTokenProvider.php98.03% <100%> (ø)32 <0> (ø)⬇️
apps/files_trashbin/lib/Expiration.php91.93% <0%> (+1.61%)29% <0%> (ø)⬇️

@skjnldsv
skjnldsv merged commit bf7620d into stable13Jun 11, 2018
@skjnldsv
skjnldsv deleted the backport/9802/stable13 branch June 11, 2018 07:17
@MorrisJobkeMorrisJobke mentioned this pull request Jun 11, 2018
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@skjnldsv