Skip to content

Make the token expiration also work for autocasting 0 - #9802

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/token_check_expire_better
Jun 9, 2018
Merged

Make the token expiration also work for autocasting 0#9802
MorrisJobke merged 1 commit into
masterfrom
bugfix/noid/token_check_expire_better

Conversation

@rullzer

@rullzerrullzer commented Jun 8, 2018

Copy link
Copy Markdown
Member

Some bad databases don't respect the default null apprently.
Now even if they cast it to 0 it should work just fine.

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

@rullzer
Make the token expiration also work for autocasting 0
480864b
Some bad databases don't respect the default null apprently.
Now even if they cast it to 0 it should work just fine.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added this to the Nextcloud 14 milestone Jun 8, 2018
@rullzer
rullzer requested review from MorrisJobke and blizzzJune 8, 2018 14:22
This was referenced Jun 8, 2018
Merged
Merged
@MorrisJobkeMorrisJobke mentioned this pull request Jun 8, 2018
Merged
@MorrisJobke

MorrisJobke commented Jun 8, 2018

Copy link
Copy Markdown
Member

This causes an endless login loop on a handful of instances.

cc @tflidd@rakekniven - we stopped also the updater for now and plan a followup release next week.

@codecov

codecovBot commented Jun 8, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9802 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@ Coverage Diff @@## master #9802 +/- ##
============================================
- Coverage 51.92% 51.92% -0.01% 
Complexity 25768 25768 ============================================
Files 1635 1635 Lines 95426 95426 Branches 1308 1308 ============================================
- Hits 49553 49552 -1 - Misses 45873 45874 +1
Impacted FilesCoverage ΔComplexity Δ
...vate/Authentication/Token/DefaultTokenProvider.php98.03% <100%> (ø)32 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.46% <0%> (-0.25%)136% <0%> (ø)

@MorrisJobke

MorrisJobke commented Jun 9, 2018

Copy link
Copy Markdown
Member

Just to be clear:

This causes an endless login loop on a handful of instances.

That was the bug that this PR fixes ;)

@MorrisJobke
MorrisJobke merged commit 0c2f016 into masterJun 9, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/noid/token_check_expire_better branch June 9, 2018 09:26
@tfliddtflidd mentioned this pull request Jun 9, 2018
Closed
@tilosptilosp mentioned this pull request Jun 10, 2018
Closed
This was referenced Jun 11, 2018
Closed
Closed
@ali-rahmanian

ali-rahmanian commented Jun 11, 2018•
edited
Loading

Copy link
Copy Markdown

I updated my nextcloud to the latest version and it was working fine. Once I log out and wanted to log in again, I faced with log in loop :'(
Cloud you please help me? I found there would be file permission but it did not solve my issue.

@MorrisJobke

MorrisJobke commented Jun 11, 2018

Copy link
Copy Markdown
Member

@ali-rahmanian On which version are you?

@ali-rahmanian

ali-rahmanian commented Jun 11, 2018

Copy link
Copy Markdown

@MorrisJobke Nextcloud 13.0.3

@MorrisJobke

MorrisJobke commented Jun 11, 2018

Copy link
Copy Markdown
Member

@ali-rahmanian This is fixed in the upcoming 13.0.4. Either choose the beta channel or wait for later today to receive the update on the stable channel.

@ali-rahmanian

ali-rahmanian commented Jun 11, 2018

Copy link
Copy Markdown

@MorrisJobke Good news. Thanks for your help (:

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 approved these changes
@blizzzblizzzblizzz approved these changes
@MorrisJobkeMorrisJobkeAwaiting requested review from MorrisJobke

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer@MorrisJobke@ali-rahmanian@icewind1991@blizzz