Skip to content

[stable12] Make the token expiration also work for autocasting 0 - #9804

Merged
skjnldsv merged 1 commit into
stable12from
backport/9802/stable12
Jun 11, 2018
Merged

[stable12] Make the token expiration also work for autocasting 0#9804
skjnldsv merged 1 commit into
stable12from
backport/9802/stable12

Conversation

@rullzer

Copy link
Copy Markdown
Member

Backport of #9802

Some bad databases don't respect the default null apprently.
Now even if they cast it to 0 it should work just fine.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Jun 8, 2018
@rullzerrullzer added this to the Nextcloud 12.0.9 milestone Jun 8, 2018
@rullzer
rullzer requested review from MorrisJobke and blizzzJune 8, 2018 14:29
@codecov

codecovBot commented Jun 8, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9804 into stable12 will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@## stable12 #9804 +/- ##
===========================================
Coverage 53.93% 53.93% Complexity 22824 22824 ===========================================
Files 1389 1389 Lines 87429 87429 Branches 1331 1331 ===========================================
Hits 47151 47151 Misses 40278 40278
Impacted FilesCoverage ΔComplexity Δ
...vate/Authentication/Token/DefaultTokenProvider.php98.01% <100%> (ø)32 <0> (ø)⬇️
lib/private/Files/Cache/Propagator.php94.93% <0%> (-1.27%)16% <0%> (ø)
apps/files_trashbin/lib/Expiration.php91.93% <0%> (+1.61%)29% <0%> (ø)⬇️

@skjnldsv
skjnldsv merged commit 07f5a2d into stable12Jun 11, 2018
@skjnldsv
skjnldsv deleted the backport/9802/stable12 branch June 11, 2018 07:17
@MorrisJobkeMorrisJobke mentioned this pull request Jun 11, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@skjnldsv