Skip to content

[stable13] Make the DELETION of groups match greedy on the groupID - #9841

Merged
MorrisJobke merged 1 commit into
stable13from
backport/9814/stable13
Jun 12, 2018
Merged

[stable13] Make the DELETION of groups match greedy on the groupID#9841
MorrisJobke merged 1 commit into
stable13from
backport/9814/stable13

Conversation

@rullzer

Copy link
Copy Markdown
Member

Backport of #9814

fixes#6032
Now since the match is greedy it will also eat the /
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Jun 12, 2018
@rullzerrullzer added this to the Nextcloud 13.0.5 milestone Jun 12, 2018
@codecov

codecovBot commented Jun 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9841 into stable13 will increase coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## stable13 #9841 +/- ##
==============================================
+ Coverage 51.43% 51.44% +<.01% 
Complexity 25135 25135 ==============================================
Files 1613 1613 Lines 95626 95626 Branches 1376 1376 ==============================================
+ Hits 49190 49191 +1 + Misses 46436 46435 -1
Impacted FilesCoverage ΔComplexity Δ
apps/provisioning_api/appinfo/routes.php0% <0%> (ø)0 <0> (ø)⬇️
apps/files_trashbin/lib/Trashbin.php72.53% <0%> (+0.24%)136% <0%> (ø)⬇️

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke
MorrisJobke merged commit 6945e1f into stable13Jun 12, 2018
@MorrisJobke
MorrisJobke deleted the backport/9814/stable13 branch June 12, 2018 20:17
@MorrisJobkeMorrisJobke mentioned this pull request Jul 10, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@skjnldsv