Skip to content

Make the DELETION of groups match greedy on the groupID - #9814

Merged
MorrisJobke merged 1 commit into
masterfrom
bugfix/6032/delete_group_with_slash
Jun 11, 2018
Merged

Make the DELETION of groups match greedy on the groupID#9814
MorrisJobke merged 1 commit into
masterfrom
bugfix/6032/delete_group_with_slash

Conversation

@rullzer

@rullzerrullzer commented Jun 9, 2018

Copy link
Copy Markdown
Member

fixes#6032

Now since the match is greedy it will also eat the /

@rullzer
Make the DELETION of groups match greedy on the groupID
228d1cf
fixes#6032
Now since the match is greedy it will also eat the /
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Jun 9, 2018
@rullzerrullzer added this to the Nextcloud 14 milestone Jun 9, 2018
@rullzerrullzer mentioned this pull request Jun 9, 2018
Closed
@codecov

codecovBot commented Jun 9, 2018•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #9814 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #9814 +/- ##
============================================
+ Coverage 51.92% 51.92% +<.01% 
Complexity 25768 25768 ============================================
Files 1635 1635 Lines 95426 95426 Branches 1308 1308 ============================================
+ Hits 49548 49552 +4 + Misses 45878 45874 -4
Impacted FilesCoverage ΔComplexity Δ
apps/provisioning_api/appinfo/routes.php0% <0%> (ø)0 <0> (ø)⬇️
apps/files_trashbin/lib/Expiration.php90.32% <0%> (-1.62%)29% <0%> (ø)
core/js/js.js65.45% <0%> (+0.55%)0% <0%> (ø)⬇️

MorrisJobke
MorrisJobke approved these changes Jun 11, 2018
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke
MorrisJobke merged commit cc78e17 into masterJun 11, 2018
@MorrisJobke
MorrisJobke deleted the bugfix/6032/delete_group_with_slash branch June 11, 2018 07:42
@MorrisJobke

MorrisJobke commented Jun 12, 2018

Copy link
Copy Markdown
Member

@rullzer Should we backport this?

@rullzerrullzer mentioned this pull request Jun 12, 2018
Merged
@rullzer

rullzer commented Jun 12, 2018

Copy link
Copy Markdown
MemberAuthor

Yep! simple one liner that fixes a pretty annoying bug so lets do it.

@rullzerrullzer mentioned this pull request Jun 12, 2018
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991
@blizzzblizzzAwaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

User groups with "/" character in the name can be deleted, but reappear

3 participants

@rullzer@MorrisJobke@skjnldsv