Skip to content

[stable12] Make the DELETION of groups match greedy on the groupID - #9842

Merged
MorrisJobke merged 1 commit into
stable12from
backport/9814/stable12
Jun 12, 2018
Merged

[stable12] Make the DELETION of groups match greedy on the groupID#9842
MorrisJobke merged 1 commit into
stable12from
backport/9814/stable12

Conversation

@rullzer

Copy link
Copy Markdown
Member

Backport of #9814

fixes#6032
Now since the match is greedy it will also eat the /
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzerrullzer added bug 3. to review Waiting for reviews labels Jun 12, 2018
@rullzerrullzer added this to the Nextcloud 12.0.10 milestone Jun 12, 2018
@codecov

codecovBot commented Jun 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #9842 into stable12 will increase coverage by <.01%.
The diff coverage is 0%.

@@ Coverage Diff @@## stable12 #9842 +/- ##
==============================================
+ Coverage 53.93% 53.93% +<.01% 
Complexity 22824 22824 ==============================================
Files 1389 1389 Lines 87429 87429 Branches 1331 1331 ==============================================
+ Hits 47151 47152 +1 + Misses 40278 40277 -1
Impacted FilesCoverage ΔComplexity Δ
apps/provisioning_api/appinfo/routes.php0% <0%> (ø)0 <0> (ø)⬇️
lib/private/Files/Cache/Propagator.php96.2% <0%> (+1.26%)16% <0%> (ø)⬇️

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

@MorrisJobke
MorrisJobke merged commit 00db9ec into stable12Jun 12, 2018
@MorrisJobke
MorrisJobke deleted the backport/9814/stable12 branch June 12, 2018 20:17
@MorrisJobkeMorrisJobke mentioned this pull request Jul 10, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rullzer@MorrisJobke@skjnldsv