Skip to content

Direct editing - #372

Merged
juliusknorr merged 10 commits into
masterfrom
enh/noid/direct-editing
Dec 4, 2019
Merged

Direct editing#372
juliusknorr merged 10 commits into
masterfrom
enh/noid/direct-editing

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Oct 21, 2019•
edited
Loading

Copy link
Copy Markdown
Member

ToDo

  • Implement postmessages

    • close
    • share
    • loading
    • loaded

  • Check for proper message calling on android

  • Hide insert image button

  • Endpoint to open workspace for folder in direct editing

    • Move to POST

  • Remove template creator once tested on Android

  • Remove dummy content from creator

  • Properly fetch direct editing token

curl -X POST 'https://admin:admin@nextcloud/ocs/v2.php/apps/text/workspace/direct?path=/&format=json' -H 'OCS-APIRequest: true' {
"ocs": {
"meta": {
"status": "ok",
"statuscode": 200,
"message": "OK"
},
"data": {
"url": "https://nextcloud.local.dev.bitgrid.net/index.php/apps/files/directEditing/SnzMyBgFy8dtePCPEF4LzSwt7XSz2xjsHCL7oGET7zbNHEB9ELHTStYbZTrX4pWn"
}
}
}

@juliusknorrjuliusknorr changed the title Direct editing🚧 Direct editingOct 21, 2019
@juliusknorrjuliusknorr mentioned this pull request Oct 21, 2019
Merged
@juliusknorrjuliusknorr mentioned this pull request Nov 4, 2019
Closed
7 tasks
@juliusknorr
juliusknorrforce-pushed the enh/noid/direct-editing branch from c020434 to db42744CompareNovember 6, 2019 09:06
@tobiasKaminskytobiasKaminsky mentioned this pull request Nov 21, 2019
Open
9 tasks
@tobiasKaminsky

tobiasKaminsky commented Nov 21, 2019

Copy link
Copy Markdown
Member

please remove for now "insert images" on mobile view.
Or can we do it the same way as in richdocuments?

@juliusknorr
juliusknorrforce-pushed the enh/noid/direct-editing branch from db42744 to fc84204CompareNovember 21, 2019 18:12
@juliusknorrjuliusknorr added 2. developing enhancement New feature or request labels Nov 21, 2019
@tobiasKaminskytobiasKaminsky mentioned this pull request Nov 26, 2019
Merged
2 tasks
@juliusknorr
juliusknorrforce-pushed the enh/noid/direct-editing branch 2 times, most recently from 469a1c9 to 3ddc2efCompareNovember 28, 2019 08:20
@juliusknorrjuliusknorr changed the title 🚧 Direct editingDirect editingNov 29, 2019
@juliusknorr
juliusknorrforce-pushed the enh/noid/direct-editing branch from 02e0ce8 to ff8a3abCompareNovember 29, 2019 19:19
@juliusknorr
Start with direct editing
baa11f4
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Properly call mobile app interfaces
5f7f70c
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Add direct editing endpoint for workspaces
a6bd992
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Hide image button for direct editing
b3c2647
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix undefined variable
1e5f5e3
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Add mimetype to creators
9d645c8
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Move to POST
c1e009c
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Remove template creator
c87396a
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Use DI for direct editing token handling
6a3b601
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Bump bundles
9e93885
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the enh/noid/direct-editing branch from ff8a3ab to 9e93885CompareDecember 2, 2019 11:30
@juliusknorr
juliusknorr merged commit e0b099d into masterDec 4, 2019
@juliusknorr
juliusknorr deleted the enh/noid/direct-editing branch December 4, 2019 17:52
@juliusknorrjuliusknorr mentioned this pull request Nov 9, 2022
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3. to reviewenhancementNew feature or request

Projects

None yet

Milestone

2.0 📋 (Nextcloud 18)

Development

Successfully merging this pull request may close these issues.

2 participants

@juliusknorr@tobiasKaminsky