Skip to content

fix: Add index to session_id on text_steps table - #4521

Merged
juliusknorr merged 2 commits into
mainfrom
bugfix/noid/add-missing-index-steps
Jul 14, 2023
Merged

fix: Add index to session_id on text_steps table#4521
juliusknorr merged 2 commits into
mainfrom
bugfix/noid/add-missing-index-steps

Conversation

@juliusknorr

@juliusknorrjuliusknorr commented Jul 14, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Adds the missing index from #4339

Fixes#4522

Requires nextcloud/server#39389

Static failure expected as the server PR is not there yet

@juliusknorrjuliusknorr mentioned this pull request Jul 14, 2023
Merged
5 tasks
@juliusknorr
juliusknorrforce-pushed the bugfix/noid/add-missing-index-steps branch from 936014a to 57db17eCompareJuly 14, 2023 09:02
@juliusknorr
juliusknorr marked this pull request as ready for review July 14, 2023 09:07
@juliusknorrjuliusknorr added bug Something isn't working 3. to review high labels Jul 14, 2023
@juliusknorrjuliusknorr added this to the Nextcloud 28 milestone Jul 14, 2023
nickvergessen
nickvergessen approved these changes Jul 14, 2023
View reviewed changes
Comment threadlib/Listeners/AddMissingIndicesListener.php Outdated
@juliusknorr
fix: Add index to session_id on text_steps table
e936863
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorrforce-pushed the bugfix/noid/add-missing-index-steps branch from 57db17e to e936863CompareJuly 14, 2023 09:25
@cypress

cypressBot commented Jul 14, 2023•
edited
Loading

Copy link
Copy Markdown

2 flaky tests on run #11103 ↗︎

014920Flakiness2

Details:

fix: Add index to session_id on text_steps table
Project: TextCommit:b953ddb627
Status: PassedDuration: 03:56 💡
Started: Jul 14, 2023 12:36 PMEnded: Jul 14, 2023 12:40 PM
Flakiness cypress/e2e/propfind.spec.js • 2 flaky tests

ViewOutputVideo

Test Artifacts
Text PROPFIND extension > with workspaces enabled > adds rich workspace property to nested folders OutputScreenshots
Text PROPFIND extension > with workspaces disabled > does not return a rich workspace property OutputScreenshots

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
chore(deps): Update nextcloud/ocp
b953ddb
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
juliusknorr merged commit 79aa84b into mainJul 14, 2023
@juliusknorr
juliusknorr deleted the bugfix/noid/add-missing-index-steps branch July 14, 2023 14:24
@juliusknorr

juliusknorr commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

/backport e936863 to stable27

@juliusknorr

juliusknorr commented Jul 14, 2023

Copy link
Copy Markdown
MemberAuthor

/backport e936863 to stable26

@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 14, 2023
Merged
@backportbot-nextcloudbackportbot-nextcloudBot mentioned this pull request Jul 14, 2023
Merged
This was referenced Jul 14, 2023
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@blizzzblizzzblizzz approved these changes
@luka-nextcloudluka-nextcloudAwaiting requested review from luka-nextcloud
@Hephi2Hephi2Awaiting requested review from Hephi2

Assignees

No one assigned

Labels

3. to reviewbugSomething isn't workinghigh

Projects

None yet

Milestone

Nextcloud 28

Development

Successfully merging this pull request may close these issues.

Slow query on 27.0.1 RC1

3 participants

@juliusknorr@nickvergessen@blizzz