fix: Delete inactive sessions in one query

[juliusknorr]

Fixes#4218

Delete inactive sessions without steps in one query as the oracle limit is only about 1000 expressions. Using one query also has the benefit to avoid deadlock scenarios as the query would lock the rows directly.

🏁 Checklist

• Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
• Sign-off message is added to all commits
• Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
• Documentation (README or documentation) has been updated or is not required

[cypress]

Passing run #10776 ↗︎

0

146

1

0

0

Details:

fix: Delete inactive sessions in one query
Project: Text	Commit:85ef18d3fa
Status: Passed	Duration: 03:49 💡
Started: Jun 29, 2023 6:52 AM	Ended: Jun 29, 2023 6:56 AM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[juliusknorr]

Sqlite somehow fails, but only on CI 🙈

1. OCA\Text\Db\SessionMapperTest::testDeleteInactiveWithoutSteps1010
   Failed asserting that actual size 1009 matches expected size 0.

/home/runner/actions-runner/_work/text/text/apps/text/tests/unit/Db/SessionMapperTest.php:97

[juliusknorr]

Let me split this to have only the query change as a backportable fix, as mentioned above the index could be considered a separate enhancement

[juliusknorr]

@blizzz@mejo- 🏓 for a review, would be nice to get this in for the next maintenance release to reduce log spam on our instance ;)

[blizzz]

@blizzz@mejo- ping_pong for a review, would be nice to get this in for the next maintenance release to reduce log spam on our instance ;)

please trigger the necessary backports

[juliusknorr]

/backport to stable27

[juliusknorr]

/backport to stable26

[backportbot-nextcloud]

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

[backportbot-nextcloud]

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport